linux-kernel - Re: [PATCH]crypto: Fix aesni algorithm implementation without test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091126001323.GA1193@gondor.apana.org.au>
Date:	Thu, 26 Nov 2009 08:13:23 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	"Youquan,Song" <youquan.song@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, ying.huang@...el.com,
	kent.liu@...el.com, youquan.song@...el.com
Subject: Re: [PATCH]crypto: Fix aesni algorithm implementation without test

On Wed, Nov 25, 2009 at 07:42:27PM -0500, Youquan,Song wrote:
> when load aesni-intel driver,kernel will report no test for some algorithm
> with AES-NI. The strange information as following:
> 
> alg: No test for __aes-aesni (__driver-aes-aesni)
> alg: No test for __ecb-aes-aesni (__driver-ecb-aes-aesni)
> alg: No test for __cbc-aes-aesni (__driver-cbc-aes-aesni)
> alg: No test for __ecb-aes-aesni (cryptd(__driver-ecb-aes-aesni)
> 
> crypto_alg's cra_name is use to descript algorithm itself, do not care the 
> concrete implement. So this patch unify them and also can fix the algorithm
> implementation without test. 
> 
> Signed-off-by: Youquan, Song <youquan.song@...el.com>

No this is bogus.  The algorithm name is specifically set to these
values because they're not meant to be used directly by anyone other
than aesni.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/