linux-kernel - Re: [PATCH RFC] Codingstyle: allow omitting braces for all single statement branches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B0EA8B0.10703@s5r6.in-berlin.de>
Date:	Thu, 26 Nov 2009 17:11:28 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
CC:	linux-kernel@...r.kernel.org, Junio C Hamano <gitster@...ox.com>,
	Randy Dunlap <rdunlap@...otime.net>,
	Teemu Likonen <tlikonen@....fi>, Jiri Kosina <jkosina@...e.cz>,
	Dan Carpenter <error27@...il.com>,
	Martin Olsson <martin@...imum.se>, linux-doc@...r.kernel.org
Subject: Re: [PATCH RFC] Codingstyle: allow omitting braces for all single
 statement branches

Uwe Kleine-König wrote:
> Grepping for "} else$" in v2.6.32-rc8 yields 6440 hits.  So this seems
> to be common practice and should be allowed.

Flawed reasoning.  Is this in new and otherwise stylistically
well-written code?  Or did you perhaps grep in old code or even in staging?

> checkpatch doesn't warn about both variants.

What checkpatch does/ can do, or doesn't, is only indirectly related to
good style or canonical style.

> --- a/Documentation/CodingStyle
> +++ b/Documentation/CodingStyle
> @@ -168,15 +168,23 @@ Do not unnecessarily use braces where a single statement will do.
>  if (condition)
>  	action();
>  
> -This does not apply if one branch of a conditional statement is a single
> -statement. Use braces in both branches.
> -
> -if (condition) {
> -	do_this();
> -	do_that();
> -} else {
> -	otherwise();
> -}
> +If not all branches of a conditional statement are single statements you might
> +use braces for both branches.
> +
> +	if (condition) {
> +		do_this();
> +		do_that();
> +	} else
> +		otherwise();
> +
> +or
> +
> +	if (condition) {
> +		do_this();
> +		do_that();
> +	} else {
> +		otherwise();
> +	}
>  
>  		3.1:  Spaces
>  

Either don't remove the existing paragraph, or remove it --- but do not
add your new either-or paragraph.  If you consider both variants to be
OK, you don't need to bloat the style guide by documenting them both.
There is no third or fourth alternative.
-- 
Stefan Richter
-=====-==--= =-== ==-=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/