linux-kernel - Re: [PATCH 7/7] kfifo: add record handling functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091126164414.GK29096@one.firstfloor.org>
Date:	Thu, 26 Nov 2009 17:44:14 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Stefani Seibold <stefani@...bold.net>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Andi Kleen <andi@...stfloor.org>,
	Amerigo Wang <xiyou.wangcong@...il.com>,
	Joe Perches <joe@...ches.com>,
	Roger Quadros <quadros.roger@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Mauro Carvalho Chehab <mchehab@...hat.com>
Subject: Re: [PATCH 7/7] kfifo: add record handling functions

On Thu, Nov 26, 2009 at 05:07:12PM +0100, Stefani Seibold wrote:
> I analyzed the code and most of them will be optimized away by the
> compiler. The reason for this design decision was that i want no
> performance regression against the old kfifo implementation.
> 
> But if the majority vote for an non inline version i will do it. It will
> make the code more readable and slim down the footprint.

I vote for smaller text size if possible. I doubt kfifo is used in any 
circumstances where a function call or two is a big problem. But of course
some inlines might be smaller than calls.

But then this code has been pending for a long time and I
have some potential users. It would be good to merge ASAP and do such tweaks 
later in tree.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/