| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20091127153432.42922230@lxorguk.ukuu.org.uk>
Date: Fri, 27 Nov 2009 15:34:32 +0000
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc: Alan Cox <alan@...ux.intel.com>, linux-kernel@...r.kernel.org,
linux-ide@...r.kernel.org
Subject: Re: [PATCH 5/5] pata_piccolo: Driver for old Toshiba chipsets
> > +#define PCI_DEVICE_ID_TOSHIBA_PICCOLO 0x0101
> > +#define PCI_DEVICE_ID_TOSHIBA_PICCOLO_2 0x0102
> > +#define PCI_DEVICE_ID_TOSHIBA_PICCOLO_3 0x0103
> > +#define PCI_DEVICE_ID_TOSHIBA_PICCOLO_5 0x0105
> > #define PCI_DEVICE_ID_TOSHIBA_TOPIC95 0x060a
> > #define PCI_DEVICE_ID_TOSHIBA_TOPIC97 0x060f
> > #define PCI_DEVICE_ID_TOSHIBA_TOPIC100 0x0617
>
> This adds kernel regression and breaks kernel build (it is generally good to
> grep kernel tree for the existing users before doing changes like the above):
>
> drivers/ide/ide-pci-generic.c:
>
> { PCI_VDEVICE(TOSHIBA, PCI_DEVICE_ID_TOSHIBA_PICCOLO), 4 },
> { PCI_VDEVICE(TOSHIBA, PCI_DEVICE_ID_TOSHIBA_PICCOLO_1), 4 },
> { PCI_VDEVICE(TOSHIBA, PCI_DEVICE_ID_TOSHIBA_PICCOLO_2), 4 },
>
> Please fix your patch.
Will do - I'll add the missing ones to ide-generic as well.
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists