Message-Id: <20091128081440.36265403.buchner.johannes@gmx.at>
Date:	Sat, 28 Nov 2009 08:14:40 +1300
From:	Johannes Buchner <buchner.johannes@....at>
To:	Frederic Weisbecker <fweisbec@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, reiserfs-devel@...r.kernel.org,
	Artem Bityutskiy <Artem.Bityutskiy@...ia.com>
Subject: Re: Fw: reiser4 git repo

Hi,

I had some issues with the reiser4 patch series from -mm.
First of all, I'm not sure what release they are based on. I used 
a8a8a669e from Linus' git repository. I applied all reiser4 patches
(except reiser4-disable of course) from
http://userweb.kernel.org/~akpm/mmotm/, which worked fine.

I think these patches are based on the reiser4-2.6.30 patch. 
I also compared them to the reiser4-2.6.31 patch, which adds some
missing pieces ([1] reiser4-from-2.6.31-patch.patch).

Additionally, some recent commits demand some changes, especially
since current_is_pdflush and generic_sync_sb_inodes are not available
any more (d8a8559cd7a9cc).
[2] reiser4-pdflush-comments.patch only fixes some comments which still
mention pdflush. 
In [3] reiser4-generic_sync_sb_inodes.patch I tried to
replace generic_sync_sb_inodes. I am not 100% sure that this is
correct, but that is what I understood from the commit diff+message of
d8a8559cd7a9cc.

The original patch
'reiser4-vfs-add-super_operationssync_inodes' introduced the call from
sync_inodes_sb to the super operation sync_inodes(sb, NULL). This NULL
pointer is dereferenced in reiser4_sync_inodes, which is fixed by
[4] reiser4-sync_inodes-null-dereference.patch.

All 4 additional patches are attached. I can only say that it works on
my machine, before I had compilation issues and freezes on 'sync'. 

Cheers,
Johannes

PS: The git repo mentioned in
http://userweb.kernel.org/~akpm/mmotm/mmotm-readme.txt is not available.

On Fri, 27 Nov 2009 04:00:51 +0100
Frederic Weisbecker <fweisbec@...il.com> wrote:

> On Fri, Nov 27, 2009 at 03:51:48PM +1300, Johannes Buchner wrote:
> > [ I sent this 2 days ago to linux-fsdevel@...r.kernel.org, maybe
> > I'll get more responses in here. ]
> > 
> > Hi!
> > 
> > I would like to keep a git repo up to date with current kernel
> > development, with reiser4 patched in. I am having trouble finding a
> > repo that provides reiser4. Is there one?
> > 
> > Some people may have noticed the last patch doesn't apply cleanly
> > anymore. I made a few lines of modifications in my local repo. Maybe
> > that repo would be interesting for others too*.
> > 
> > I plan to catch up with changes from kernel development on a
> > daily/weekly basis; my /home partition is reiser4, so I am fairly
> > serious about it.
> > 
> > At the moment, I fetch from torvalds/linux-2.6.git and 
> > stable/linux-2.6.31.y.git. Am I missing any other repositories that
> > I should try to keep up with? (A fs subsystem maintainer repo?)
> > next/linux-next.git is probably moving too fast for me.
> 
> 
> You can try the -mm tree, the reiser 4 patches can be found inside:
> 
> http://userweb.kernel.org/~akpm/mmotm/

-- 
Emails können geändert, gefälscht und eingesehen werden. Signiere oder
verschüssele deine Mails mit GPG.
http://web.student.tuwien.ac.at/~e0625457/pgp.html



Download attachment "series" of type "application/octet-stream" (1116 bytes)

View attachment "reiser4-from-2.6.31-patch.patch" of type "text/x-patch" (6161 bytes)

View attachment "reiser4-pdflush-comments.patch" of type "text/x-patch" (1682 bytes)

View attachment "reiser4-generic_sync_sb_inodes.patch" of type "text/x-patch" (1199 bytes)

View attachment "reiser4-sync_inodes-null-dereference.patch" of type "text/x-patch" (612 bytes)

Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists