linux-kernel - Re: [PATCH] change PCI nomenclature according to PCI-SIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3hbsezt2c.fsf@intrepid.localdomain>
Date:	Sat, 28 Nov 2009 14:18:19 +0100
From:	Krzysztof Halasa <khc@...waw.pl>
To:	Stefan Assmann <sassmann@...hat.com>
Cc:	linux-pci@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Don Dutile <ddutile@...hat.com>, kaneshige.kenji@...fujitsu.com
Subject: Re: [PATCH] change PCI nomenclature according to PCI-SIG

Stefan Assmann <sassmann@...hat.com> writes:

> --- a/drivers/firmware/edd.c
> +++ b/drivers/firmware/edd.c
> @@ -150,7 +150,7 @@ edd_show_host_bus(struct edd_device *edev, char *buf)
>  	if (!strncmp(info->params.host_bus_type, "ISA", 3)) {
>  		p += scnprintf(p, left, "\tbase_address: %x\n",
>  			     info->params.interface_path.isa.base_address);
> -	} else if (!strncmp(info->params.host_bus_type, "PCIX", 4) ||
> +	} else if (!strncmp(info->params.host_bus_type, "PCI-X", 4) ||
>  		   !strncmp(info->params.host_bus_type, "PCI", 3)) {

This one looks like a BIOS binary interface so you can't change it.

> --- a/drivers/net/igb/e1000_mac.c
> +++ b/drivers/net/igb/e1000_mac.c
> @@ -1256,7 +1256,7 @@ s32 igb_led_off(struct e1000_hw *hw)
>  }
>
>  /**
> - *  igb_disable_pcie_master - Disables PCI-express master access
> + *  igb_disable_pcie_master - Disables PCIe.press master access
>   *  @hw: pointer to the HW structure

This one needs fixing.

> @@ -2066,7 +2066,7 @@ out:
>  }
>
>  /**
> - *  ixgbe_disable_pcie_master - Disable PCI-express master access
> + *  ixgbe_disable_pcie_master - Disable PCIe.press master access
>   *  @hw: pointer to hardware structure

Same here.

> --- a/drivers/staging/rt3090/common/cmm_mac_pci.c
> +++ b/drivers/staging/rt3090/common/cmm_mac_pci.c
> @@ -1481,7 +1481,7 @@ BOOLEAN RT28xxPciAsicRadioOff(
>  	*/
>  #endif // CONFIG_STA_SUPPORT //
>  //KH Debug:My original codes have the follwoing codes, but currecnt codes do not have it.
> -// Disable for stability. If PCIE Link Control is modified for advance power save, re-covery this code segment.
> +// Disable for stability. If PCIe Link Control is modified for advance power save, re-covery this code segment.

While it has nothing to do with PCIe... You may want to fix it as well.
"follwoing", "currecnt", what does "advance power save" do? What does
the "re-covery this code segment" means? Staging standard.

> --- a/drivers/staging/rt3090/common/rtmp_init.c
> +++ b/drivers/staging/rt3090/common/rtmp_init.c
> @@ -3512,7 +3512,7 @@ int rt28xx_init(
>
>  #ifdef RTMP_MAC_PCI
>  #ifdef PCIE_PS_SUPPORT
> -	/*Iverson patch PCIE L1 issue to make sure that driver can be read,write ,BBP and RF register  at pcie L.1 level */
> +	/*Iverson patch PCIe L1 issue to make sure that driver can be read,write ,BBP and RF register  at pcie L.1 level */
                                                                                                     ^^^^^^^^^^
Should be changed as well I think. "can be read,write", well.

Otherwise, the patch looks IMHO good.
-- 
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/