linux-kernel - avoiding duplicate icache flushing of shared maps on nommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0911280740p24ad49bal64b924a427abfa39@mail.gmail.com>
Date:	Sat, 28 Nov 2009 10:40:30 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	David Howells <dhowells@...hat.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	Bernd Schmidt <bernds_cb1@...nline.de>,
	Jie Zhang <jie.zhang@...log.com>
Cc:	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	uclinux-dist-devel <uclinux-dist-devel@...ckfin.uclinux.org>
Subject: avoiding duplicate icache flushing of shared maps on nommu

when working with FDPIC, there are many shared maps of read only text
regions (the C library, applet packages like busybox, ...) between
applications.  but the current mm/nommu.c:do_mmap_pgoff() function
will issue an icache flush whenever a vma is added to a mm instead of
only doing it when the map is initially created.  am i missing
something obvious here, or would a change like below be OK ?  this
easily cuts the number of icache flushes during boot by 50% if not
more.

(yes, this now does the icache flush while holding the
nommu_region_sem, but i'm interested if the _idea_ is OK)

--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -1409,14 +1409,14 @@ unsigned long do_mmap_pgoff(struct file *file,

    current->mm->total_vm += len >> PAGE_SHIFT;

+   if (prot & PROT_EXEC)
+       flush_icache_range(result, result + len);
+
 share:
    add_vma_to_mm(current->mm, vma);

    up_write(&nommu_region_sem);

-   if (prot & PROT_EXEC)
-       flush_icache_range(result, result + len);
-
    kleave(" = %lx", result);
    return result;

-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/