linux-kernel - Re: [PATCH] change PCI nomenclature according to PCI-SIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m34ood6nsp.fsf@intrepid.localdomain>
Date:	Sun, 29 Nov 2009 22:09:26 +0100
From:	Krzysztof Halasa <khc@...waw.pl>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Stefan Assmann <sassmann@...hat.com>, linux-pci@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Don Dutile <ddutile@...hat.com>, kaneshige.kenji@...fujitsu.com
Subject: Re: [PATCH] change PCI nomenclature according to PCI-SIG

Jeff Garzik <jeff@...zik.org> writes:

> Think about this from an engineering perspective.  This patch is
> driven not by any real technical need, but more by marketing and
> trademark folks.

Uh, I'm not sure about this. It would be much better if the kernel was
consistent in naming the PCI versions, not like today: PCIe, PCIE,
PCI-E, PCI-express, PCI-X, PCIX etc, including the user-visible cases
(but obviously not the EDD and similar things).

But I think it should be handler by individual maintainers.

> Finally, split your patch up.  I would suggest starting with 100%
> comment changes that are guaranteed with mathematical certainty to not
> change the compiler-generated code at all.  That will make the
> remaining changes much easier to review, if they are in separate
> patches from the comment-only changes.

Absolutely. Perhaps that older PCI patch should be done first, it was
a good one IIRC.
-- 
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/