linux-kernel - Re: [PATCH 19/41] union-mount: Introduce MNT_UNION and MS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200911300802.nAU82iLC022867@agora.fsl.cs.sunysb.edu>
Date:	Mon, 30 Nov 2009 03:02:44 -0500
From:	Erez Zadok <ezk@...sunysb.edu>
To:	Valerie Aurora <vaurora@...hat.com>
Cc:	Jan Blunck <jblunck@...e.de>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Christoph Hellwig <hch@...radead.org>,
	Andy Whitcroft <apw@...onical.com>,
	Scott James Remnant <scott@...onical.com>,
	Sandu Popa Marius <sandupopamarius@...il.com>,
	Jan Rekorajski <baggins@...h.mimuw.edu.pl>,
	"J. R. Okajima" <hooanon05@...oo.co.jp>,
	Arnd Bergmann <arnd@...db.de>,
	Vladimir Dronnikov <dronnikov@...il.com>,
	Felix Fietkau <nbd@...nwrt.org>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, Miklos Szeredi <mszeredi@...e.cz>
Subject: Re: [PATCH 19/41] union-mount: Introduce MNT_UNION and MS_UNION flags 

In message <1256152779-10054-20-git-send-email-vaurora@...hat.com>, Valerie Aurora writes:
> From: Jan Blunck <jblunck@...e.de>
> 
> Add per mountpoint flag for Union Mount support. You need additional patches
> to util-linux for that to work - see:
> 
> git://git.kernel.org/pub/scm/utils/util-linux-ng/val/util-linux-ng.git
> 
> Signed-off-by: Jan Blunck <jblunck@...e.de>
> Signed-off-by: Miklos Szeredi <mszeredi@...e.cz>
> Signed-off-by: Valerie Aurora <vaurora@...hat.com>
> ---
>  fs/namespace.c        |    5 ++++-
>  include/linux/fs.h    |    1 +
>  include/linux/mount.h |    1 +
>  3 files changed, 6 insertions(+), 1 deletions(-)
[...]

> diff --git a/include/linux/mount.h b/include/linux/mount.h
> index 5d52753..e175c47 100644
> --- a/include/linux/mount.h
> +++ b/include/linux/mount.h
> @@ -35,6 +35,7 @@ struct mnt_namespace;
>  #define MNT_SHARED	0x1000	/* if the vfsmount is a shared mount */
>  #define MNT_UNBINDABLE	0x2000	/* if the vfsmount is a unbindable mount */
>  #define MNT_PNODE_MASK	0x3000	/* propagation flag mask */
> +#define MNT_UNION	0x4000	/* if the vfsmount is a union mount */

I it correct to just add another flag here?  How does it relate to this
'propagation mask' right above it?  If there's some code out there which
masks out which MNT flags get propagated and which don't, then you need to
make a decision whether MNT_UNION needs to be propagated as well.  Either
way, please document your decision in a comment here so no one will have to
ask the same question again.

Erez.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/