linux-kernel - [Patch] fs: move a definition out of switch block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 30 Nov 2009 04:36:30 -0500
From:	Amerigo Wang <amwang@...hat.com>
To:	linux-kernel@...r.kernel.org
Cc:	Matthew Wilcox <matthew@....cx>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Jonathan Corbet <corbet@....net>,
	Oleg Nesterov <oleg@...hat.com>,
	Christoph Hellwig <hch@....de>,
	Amerigo Wang <amwang@...hat.com>,
	linux-fsdevel@...r.kernel.org, akpm@...ux-foundation.org
Subject: [Patch] fs: move a definition out of switch block


It's not a good practice to leave a definition between
'switch' and the its first label.

Move it out of the switch block.

Signed-off-by: WANG Cong <amwang@...hat.com>
Cc: Matthew Wilcox <matthew@....cx>
Cc: Alexander Viro <viro@...iv.linux.org.uk>
Cc: Jonathan Corbet <corbet@....net>
Cc: Oleg Nesterov <oleg@...hat.com>
Cc: Christoph Hellwig <hch@....de>

---
diff --git a/fs/fcntl.c b/fs/fcntl.c
index 2cf93ec..23b0238 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -514,12 +514,12 @@ static void send_sigio_to_task(struct task_struct *p,
 	 * sure we read it once and use the same value throughout.
 	 */
 	int signum = ACCESS_ONCE(fown->signum);
+	siginfo_t si;
 
 	if (!sigio_perm(p, fown, signum))
 		return;
 
 	switch (signum) {
-		siginfo_t si;
 		default:
 			/* Queue a rt signal with the appropriate fd as its
 			   value.  We use SI_SIGIO as the source, not 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/