linux-kernel - Re: [PATCH] fs/ext2: ext2_readdir comment about returns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091130111755.GB4240@quack.suse.cz>
Date:	Mon, 30 Nov 2009 12:17:56 +0100
From:	Jan Kara <jack@...e.cz>
To:	Jérémy Cochoy <jeremy.cochoy@...il.com>
Cc:	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jan Kara <jack@...e.cz>, Pavel Machek <pavel@...e.cz>,
	Al Viro <viro@...iv.linux.org.uk>, ronny.pretzsch@....de,
	Corentin Chary <corentin.chary@...il.com>
Subject: Re: [PATCH] fs/ext2: ext2_readdir comment about returns

  Hello,

On Mon 30-11-09 00:30:55, Jérémy Cochoy wrote:
> From:Jeremy Cochoy <jeremy.cochoy@...il.com>
> I submit a short correction about a comment in ext2/dir.c
> 
> (I've already send it but it wasn't the good patch format and i didn't
> cc the right people.)
> 
> PS: Please excuse me if I make mistakes with the netiquette, it's my
> first patch and i wich to send more useful patchs next time, without
> hurting your eyes.
  Thanks for the patch. I'd like to point you to the
Documentation/SubmittingPatches document where is described how a proper
patch submission should look like. Most importantly I miss a Signed-off-by
line (item 12 in the document) - without it the patch cannot be merged.
Also your description in the subject is inaccurate. In my opinion it should
rather be:
ext2: Fixup description of ext2_find_entry
  Finally, it's easier to handle submitted patches with git tools when the
body of email looks like:
Something I want in the changelog additionally to mail subject line
(probably empty in your case).
---
Something that I want to say but should not end up in the changelog.

Patch.

Seeing that you have probably generated your patch from git, git
format-patch and git send-email are useful commands for submitting patches
via email.

								Honza
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/