| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Nov 2009 20:19:36 +0900 From: Magnus Damm <magnus.damm@...il.com> To: Thomas Gleixner <tglx@...utronix.de> Cc: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, linux-sh@...r.kernel.org, johnstul@...ibm.com, lethal@...ux-sh.org Subject: Re: [PATCH 02/02] clocksource: Start CMT at clocksource resume Hi Thomas, On Sat, Nov 28, 2009 at 11:00 PM, Thomas Gleixner <tglx@...utronix.de> wrote: > On Wed, 25 Nov 2009, Magnus Damm wrote: > >> From: Magnus Damm <damm@...nsource.se> >> >> Add code to start the CMT timer on clocksource resume. >> >> This makes sure the timer is started during sysdev_resume(). >> Without this patch the clocksource may be read as suspended, >> this after sysdev resume but before platform device resume. > > Hmm, don't you have the same situation on suspend ? > > platform device suspend stops the clock, but the generic code expects > it to be running until sysdev shutdown. You are correct, the same situation exists on suspend. > Another thing is that you now run both, the sysdev and the platform > resume. Is that by design or accident ? By incorrect design. =) To fix this properly I was thinking of adding a clocksource suspend() callback and ditch the platform ops all together. If you don't mind then I'll post a patch for that tomorrow! Thank you! / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists