linux-kernel - Re: [rfc] "fair" rw spinlocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0911300722370.2872@localhost.localdomain>
Date:	Mon, 30 Nov 2009 07:52:26 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Christoph Hellwig <hch@...radead.org>
cc:	Nick Piggin <npiggin@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [rfc] "fair" rw spinlocks

On Mon, 30 Nov 2009, Christoph Hellwig wrote:
> 
> How long will this use be around?  I've seen some slow progress toward
> replacing most read side uses of the task list lock with RCU.  While we
> still have lots of read side users now I wonder when they'll go away.

tasklist_lock is pretty nasty. I threw out "replace it with RCU" because 
it would be nice, but the data structures used are not just simple linked 
lists that we have RCU helpers for traversing.

There are various real exclusion rules about things like 'tsk->exit_state' 
etc, which do not translate directly to RCU usage. Of course, _maybe_ all 
the places that care already take the thing for writing and would just 
automatically have exclusion anyway.

So I'd love to see somebody try to do the conversion. To a first 
approximation, you probably could do

 - turn tasklist_lock into a spinlock

 - sed 's/write_lock_irq(&tasklist_lock)/spin_lock(&tasklist_lock)/g'
   sed 's/write_unlock_irq(&tasklist_lock)/spin_unlock(&tasklist_lock)/g'

 - sed 's/read_lock(&tasklist_lock)/rcu_read_lock()/g'
   sed 's/read_unlock(&tasklist_lock)/rcu_read_unlock()/g'

 - make all the task lists use the RCU versions of the list routines

 - free the task structure using RCU

and you'd be _pretty_ close to a working system.

But I'd worry about current read-lockers that depend on things like that 
tsk->exit_state thing being stable from just read-locking (since only 
write-lockers should change it). So you can _probably_ do 99% of it fairly 
mindlessly, but the remaining 1% is the subtle stuff.

Maybe it's easier than I think. Or maybe I've totally ignored something, 
and there are much much worse issues than the occasional exit_state thing.
(Things like 'tsk->mm' are already protected by per-task locks, but there 
may be other things that depend on holding tasklist lock for exclusion).

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/