| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Nov 2009 18:34:46 +0200 From: Nir Tzachar <nir.tzachar@...il.com> To: Michal Marek <mmarek@...e.cz> Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, sam@...nborg.org, zippel@...ux-m68k.org, andi@...stfloor.org, randy.dunlap@...cle.com, elendil@...net.nl, bn@...sdigital.com Subject: Re: [PATCH] nconfig v7 Hi Michal On Mon, Nov 30, 2009 at 4:40 PM, Michal Marek <mmarek@...e.cz> wrote: > On 25.11.2009 11:28, nir.tzachar@...il.com wrote: >> Hello. >> >> Attached bellow is version 7 of nconfig, an ncurses based replacement for >> menuconfig. After a thorough overhaul, addressing all concerns raised in the >> past by users on these lists, I would be happy if this version is favorably >> considered for inclusion. >> >> Major changes since version 6: >> >> 1) un-selectable menu items have 'XXX' before them, to indicate the fact. >> 2) there are three separate help menus: main help (bound to F1), symbol help >> (bound to F2 and 'h') and short instructions (bound to F3). > > Hi Nir, > > I tried it a few times, it's nice :). I get a few warnings about missing > prototypes when compiling it: > HOSTCC scripts/kconfig/nconf.gui.o > scripts/kconfig/nconf.gui.c:23: warning: no previous prototype for > ‘set_normal_colors’ > scripts/kconfig/nconf.gui.c:68: warning: no previous prototype for > ‘normal_color_theme’ > scripts/kconfig/nconf.gui.c:100: warning: no previous prototype for > ‘no_colors_theme’ > HOSTCC scripts/kconfig/nconf.o > scripts/kconfig/nconf.c:455: warning: no previous prototype for > ‘process_special_keys’ > scripts/kconfig/nconf.c:487: warning: no previous prototype for > ‘get_next_hot’ > scripts/kconfig/nconf.c:506: warning: no previous prototype for ‘canbhot’ > scripts/kconfig/nconf.c:514: warning: no previous prototype for ‘is_hot’ > scripts/kconfig/nconf.c:522: warning: no previous prototype for ‘make_hot’ > scripts/kconfig/nconf.c:582: warning: no previous prototype for ‘item_make’ > scripts/kconfig/nconf.c:626: warning: no previous prototype for > ‘item_add_str’ > scripts/kconfig/nconf.c:656: warning: no previous prototype for ‘item_tag’ > scripts/kconfig/nconf.c:668: warning: no previous prototype for > ‘curses_item_index’ > scripts/kconfig/nconf.c:673: warning: no previous prototype for ‘item_data’ > scripts/kconfig/nconf.c:684: warning: no previous prototype for > ‘item_is_tag’ > scripts/kconfig/nconf.c:691: warning: no previous prototype for > ‘set_config_filename’ I'll try to fix these. > These probably can be static. Oh, and when I suspend the program with > Ctrl-Z, resume with 'fg' and hit an arrow key, the escape sequence is > interpreted as a genuine ESC and it either jumps one menu level above or > wants to exit the program. It happens to me both in xterm and > gnome-terminal, ncurses version is 5.6. Can you see it as well or is > there something broken on my side? I get the same behavior on my system. Try changing the cbreak() in nconfig.c to raw(), which will disable signal generation for ^Z and ^C. > Other than that, I found no issues so far (except for the not really > readable shortcut nOtation, but you say it's hard to fix, so let's > forget about it for now). I'll use it a bit more and have a look at the > code. For now, it is in git://repo.or.cz/linux-kbuild.git#for-review as is. Thanks :) > Michal > Cheers, Nir. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists