linux-kernel - Re: [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091130185813.GA32522@oksana.dev.rtsoft.ru>
Date:	Mon, 30 Nov 2009 21:58:13 +0300
From:	Anton Vorontsov <avorontsov@...mvista.com>
To:	Madhusudhan <madhu.cr@...com>
Cc:	'Grazvydas Ignotas' <notasas@...il.com>,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI
 charger

On Mon, Nov 30, 2009 at 12:45:20PM -0600, Madhusudhan wrote:
[...]
> > +	case POWER_SUPPLY_PROP_VOLTAGE_NOW:
> > +		/* charging must be active for meaningful result */
> > +		if (!is_charging) {
> 
> How about putting a kern_info here?

It might be better to return -EINVAL.

Thanks!

-- 
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/