linux-kernel - Re: futex_cmpxchg_enabled not set in futex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Nov 2009 13:36:40 -0800
From:	Darren Hart <dvhltc@...ibm.com>
To:	Joseph Parmelee <jparmele@...dbear.com>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...e.hu>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Dinakar Guniguntala <dino@...ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: futex_cmpxchg_enabled not set in futex_init on pentium3

Joseph Parmelee wrote:

Hi Joseph,

Adding futex folks on CC.

> Greetings all:
> 
> Sometime between 2.6.28.6 and 2.6.31.5 a regression (feature?) in the futex
> system now causes futex test failures on glibc-2.9 which where not present
> before.  That is, recompiling the binaries of glibc-2.9 and rerunning its
> test suite now produces futex errors that passed previously.  The problem
> appears now with glibc-2.9 compiled with either gcc-4.1.2 or gcc-4.4.2, and
> with glibc-2.11 compiled with gcc-4.4.2, which is what I am currently
> running on this machine, failures and all.
> 
> The system under discussion is a uniprocessor pentium3 with an AMI BIOS. 
> Full details available on request should that prove necessary.
> 
> I have tracked the test failures down to the fact that 
> futex_cmpxchg_enabled
> is not set because the test in futex_init now "fails" (actually 
> succeeds). This appears to be happening because the expected page fault 
> intentionally
> provoked by a null dereference appears to be working now in kernel mode. 
> This *may* (rank speculation) be associated with the AMI BIOS low-memory
> corruption protection added sometime during this gap, and which is 
> activated
> on this machine.

Hrm... interesting...

> 
> Before I muck any further with this, especially involving the quite tricky
> futex mess, I would appreciate some insight into the idea behind the 
> test in
> futex_init.  I don't understand why you would bother to invoke a fault in
> what is apparently a test to determine if the cmpxchg instruction works. 

I suspect this is because the test asks for a userspace address. So rather
than hack something up to use a real userspace address, we just send NULL.
EFAULT=success and ENOSYS=failure.

> The fault is supposed to occur as a result of a null dereference that takes
> place *before* the cmpxchg instruction is even executed.  If you want to
> test that cmpxchg works, why not just make a little test in futex_init that
> uses it and fails (not succeeds) if it doesn't behave as expected, or if
> there is a fault of some kind (like illegal instruction)?  Or is the fact
> that we don't get a fault the whole point here?

I believe the NULL pointer is just a convenience.


-- 
Darren Hart
IBM Linux Technology Center
Real-Time Linux Team
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/