linux-kernel - Re: [PATCH] PCI: Always set prefetchable base/limit upper32 registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Nov 2009 14:43:57 -0700
From:	Alex Williamson <alex.williamson@...com>
To:	Grant Grundler <grundler@...isc-linux.org>
Cc:	jbarnes@...tuousgeek.org, yinghai@...nel.org,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: Always set prefetchable base/limit upper32
 registers

On Mon, 2009-11-30 at 14:42 -0700, Grant Grundler wrote:
> On Mon, Nov 30, 2009 at 02:22:53PM -0700, Alex Williamson wrote:
> > diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
> > index cb1a027..127d759 100644
> > --- a/drivers/pci/setup-bus.c
> > +++ b/drivers/pci/setup-bus.c
> > @@ -221,11 +221,9 @@ static void pci_setup_bridge(struct pci_bus *bus)
> >  	}
> >  	pci_write_config_dword(bridge, PCI_PREF_MEMORY_BASE, l);
> >  
> > -	if (pref_mem64) {
> > -		/* Set the upper 32 bits of PREF base & limit. */
> > -		pci_write_config_dword(bridge, PCI_PREF_BASE_UPPER32, bu);
> > -		pci_write_config_dword(bridge, PCI_PREF_LIMIT_UPPER32, lu);
> > -	}
> 
> Why not remove all references to pref_mem64?
> This was the only use AFAICT.

Ah, good point, I'll send a v2.  Thanks Grant.

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/