linux-kernel - [PATCH] percpu: refactor the code in pcpu_[de]populate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B14C217.90203@redhat.com>
Date:	Tue, 01 Dec 2009 15:13:27 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Tejun Heo <tj@...nel.org>
CC:	Christoph Lameter <cl@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: [PATCH] percpu: refactor the code in pcpu_[de]populate_chunk()

Tejun Heo wrote:
> On 12/01/2009 03:35 PM, Cong Wang wrote:
>> What do you think about the patch below? Untested.
> 
> Oh, yeah, that's prettier.  Just one thing, can you please move rs
> initialization right above the pcpu_next_[un]pop() call?  The
> input/output parameters for those functions are already pretty
> confusing, let's make it at least a bit clearer.
> 

Sure, done.

------------->

Using break statement at the end of a for loop is confusing,
refactor it by replacing the for loop.

Signed-off-by: WANG Cong <amwang@...hat.com>

---


View attachment "mm-percpu_c-remove-two-useless-break.diff" of type "text/plain" (1148 bytes)