linux-kernel - Re: [PATCH] slow-work: Fix build bug in the !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091201183201.0c56f119.sfr@canb.auug.org.au>
Date:	Tue, 1 Dec 2009 18:32:01 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	David Howells <dhowells@...hat.com>, torvalds@...l.org,
	akpm@...ux-foundation.org, steved@...hat.com,
	jens.axboe@...cle.com, linux-cachefs@...hat.com,
	nfsv4@...ux-nfs.org, linux-fsdevel@...r.kernel.org,
	cluster-devel@...hat.com, linux-kernel@...r.kernel.org,
	linux-cifs-client@...ts.samba.org, linux-next@...r.kernerl.org
Subject: Re: [PATCH] slow-work: Fix build bug in the !CONFIG_MODULES case

Hi Ingo,

On Tue, 1 Dec 2009 07:56:05 +0100 Ingo Molnar <mingo@...e.hu> wrote:
>
> these slow-work changes have introduced a new !CONFIG_MODULES build bug 
> on x86 (and all other architectures i suspect):

Thanks for the heads up!

> From: Ingo Molnar <mingo@...e.hu>
> Date: Tue, 1 Dec 2009 07:47:52 +0100
> Subject: [PATCH] slow-work: Fix build bug in the !CONFIG_MODULES case
> 
> Commit 3bde31a ("SLOW_WORK: Allow a requeueable work item to sleep till
> the thread is needed") broke the !CONFIG_MODULES build by relying on
> variables that are only available (and only make sense) with module
> support enabled. Fix it.
> 
> Cc: David Howells <dhowells@...hat.com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>

I have applied this to linux-next for today, just so people don't waste
their time finding this breakage again.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped