linux-kernel - Re: [PATCH 1/2] hw_random: core updates to allow more efficient drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B14E08B.3010504@collabora.co.uk>
Date:	Tue, 01 Dec 2009 09:23:23 +0000
From:	Ian Molton <ian.molton@...labora.co.uk>
To:	Rusty Russell <rusty@...tcorp.com.au>
CC:	Matt Mackall <mpm@...enic.com>, linux-kernel@...r.kernel.org,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Jeff Garzik <jeff@...zik.org>
Subject: Re: [PATCH 1/2] hw_random: core updates to allow more efficient drivers

Rusty Russell wrote:

> But we're bikeshedding, so apply or revert.
> 
> 	/* A buffer which can hold any fundamental type: drivers are fussy. */
> 	static u8 rng_buffer[SMP_CACHE_BYTES < 8 ? 8 : SMP_CACHE_BYTES]
> 		__cacheline_aligned;

One nit - theres one driver where <24 bytes will be quite suboptimal.
I'd say pick 32 bytes, which is a common cachline size, too.

> Either way, both patches: Acked-by: Rusty Russell <rusty@...tcorp.com.au>

Thanks!

-Ian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/