linux-kernel - Re: [PATCH] perf_event: initialize data.period in perf_swevent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1259660225.26472.594.camel@laptop>
Date:	Tue, 01 Dec 2009 10:37:05 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf_event: initialize data.period in
 perf_swevent_hrtimer()

On Tue, 2009-12-01 at 17:30 +0800, Xiao Guangrong wrote:
> In current code in perf_swevent_hrtimer(), data.period is not initialized,

Ah, very nice catch.

Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>

> Signed-off-by: Xiao Guangrong <xiaoguangrong@...fujitsu.com>
> ---
>  kernel/perf_event.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/perf_event.c b/kernel/perf_event.c
> index 0b9ca2d..040ee51 100644
> --- a/kernel/perf_event.c
> +++ b/kernel/perf_event.c
> @@ -4010,6 +4010,7 @@ static enum hrtimer_restart perf_swevent_hrtimer(struct hrtimer *hrtimer)
>  	event->pmu->read(event);
>  
>  	data.addr = 0;
> +	data.period = event->hw.last_period;
>  	regs = get_irq_regs();
>  	/*
>  	 * In case we exclude kernel IPs or are somehow not in interrupt


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/