linux-kernel - Re: [PATCH] bsdacct: fix uid/gid misreporting (#14676)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091201144319.GA32117@us.ibm.com>
Date:	Tue, 1 Dec 2009 08:43:19 -0600
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	akpm@...ux-foundation.org, jkj@...si.fi,
	linux-kernel@...r.kernel.org, mschmidt@...hat.com,
	dhowells@...hat.com, jmorris@...ei.org
Subject: Re: [PATCH] bsdacct: fix uid/gid misreporting (#14676)

Quoting Alexey Dobriyan (adobriyan@...il.com):
> commit d8e180dcd5bbbab9cd3ff2e779efcf70692ef541
> "bsdacct: switch credentials for writing to the accounting file"
> introduced credential switching during final acct data collecting.
> However, uid/gid pair continued to be collected from current which
> became credentials of who created acct file, not who exits.
> 
> Fix http://bugzilla.kernel.org/show_bug.cgi?id=14676
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>

Yeah seems like it wouuld be needed, thanks.

Acked-by: Serge Hallyn <serue@...ibm.com>

> ---
> 
>  Juho, please, confirm.
> 
>  kernel/acct.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- a/kernel/acct.c
> +++ b/kernel/acct.c
> @@ -536,7 +536,8 @@ static void do_acct_process(struct bsd_acct_struct *acct,
>  	do_div(elapsed, AHZ);
>  	ac.ac_btime = get_seconds() - elapsed;
>  	/* we really need to bite the bullet and change layout */
> -	current_uid_gid(&ac.ac_uid, &ac.ac_gid);
> +	ac.ac_uid = orig_cred->uid;
> +	ac.ac_gid = orig_cred->gid;
>  #if ACCT_VERSION==2
>  	ac.ac_ahz = AHZ;
>  #endif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/