linux-kernel - Re: [PATCH] SLOW_WORK: Move slow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0912010821170.2872@localhost.localdomain>
Date:	Tue, 1 Dec 2009 08:24:52 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	David Howells <dhowells@...hat.com>, akpm@...ux-foundation.org,
	steved@...hat.com, jens.axboe@...cle.com, linux-cachefs@...hat.com,
	nfsv4@...ux-nfs.org, linux-fsdevel@...r.kernel.org,
	cluster-devel@...hat.com, linux-kernel@...r.kernel.org,
	linux-cifs-client@...ts.samba.org
Subject: Re: [PATCH] SLOW_WORK: Move slow_work's proc file to debugfs



On Tue, 1 Dec 2009, Ingo Molnar wrote:
> 
> Nice - thanks for doing this so quickly! It might sound like nitpicking 
> but /proc ABIs tend to be a lot harder to get rid of than debugfs 
> interfaces.

Ok, I applied it, so we'll not switch interfaces (even if they are just 
for debugging) across releases.

Btw David, for things like this, it's _really_ nice to use git rename 
detection. The diffstat (w/ summary) with rename detection looks like 
this:

 Documentation/slow-work.txt                      |    4 ++--
 include/linux/slow-work.h                        |    8 ++++----
 init/Kconfig                                     |    8 ++++----
 kernel/Makefile                                  |    2 +-
 kernel/{slow-work-proc.c => slow-work-debugfs.c} |    4 ++--
 kernel/slow-work.c                               |   18 ++++++++++++------
 kernel/slow-work.h                               |    6 +++---
 7 files changed, 28 insertions(+), 22 deletions(-)
 rename kernel/{slow-work-proc.c => slow-work-debugfs.c} (97%)

which makes it obvious that the changes were really just about renaming. 
Compare to the non-rename-aware one:

 Documentation/slow-work.txt |    4 +-
 include/linux/slow-work.h   |    8 +-
 init/Kconfig                |    8 +-
 kernel/Makefile             |    2 +-
 kernel/slow-work-debugfs.c  |  227 +++++++++++++++++++++++++++++++++++++++++++
 kernel/slow-work-proc.c     |  227 -------------------------------------------
 kernel/slow-work.c          |   18 +++-
 kernel/slow-work.h          |    6 +-
 8 files changed, 253 insertions(+), 247 deletions(-)
 create mode 100644 kernel/slow-work-debugfs.c
 delete mode 100644 kernel/slow-work-proc.c

where you can kind of guess that slow-work-[proc|debugfs].c are largely 
the same, but you don't actually _see_ that it only has four lines of 
changes (and the patch then shows that the changes are just to comments).

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/