linux-kernel - Re: [PATCH 41/41] union-mount: Add support for rename by __union

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200912010457.nB14vRim030930@agora.fsl.cs.sunysb.edu>
Date:	Mon, 30 Nov 2009 23:57:27 -0500
From:	Erez Zadok <ezk@...sunysb.edu>
To:	Valerie Aurora <vaurora@...hat.com>
Cc:	Jan Blunck <jblunck@...e.de>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Christoph Hellwig <hch@...radead.org>,
	Andy Whitcroft <apw@...onical.com>,
	Scott James Remnant <scott@...onical.com>,
	Sandu Popa Marius <sandupopamarius@...il.com>,
	Jan Rekorajski <baggins@...h.mimuw.edu.pl>,
	"J. R. Okajima" <hooanon05@...oo.co.jp>,
	Arnd Bergmann <arnd@...db.de>,
	Vladimir Dronnikov <dronnikov@...il.com>,
	Felix Fietkau <nbd@...nwrt.org>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, Jan Blunck <jblunck@...radead.org>
Subject: Re: [PATCH 41/41] union-mount: Add support for rename by __union_copyup() 

In message <1256152779-10054-42-git-send-email-vaurora@...hat.com>, Valerie Aurora writes:
> From: Jan Blunck <jblunck@...radead.org>
> 
> It is possible to use __union_copyup() to support rename of regular files
> without returning -EXDEV.
> 
> XXX - Rewrite as copyup to old name followed by rename() + whiteout()

All this code just to support rename by copyup?!  I can see why we're
looking for other tricks, such as symlinks...

> Signed-off-by: Jan Blunck <jblunck@...radead.org>
> Signed-off-by: Valerie Aurora <vaurora@...hat.com>

> +//	error = hash_lookup_union(&oldnd, &oldnd.last, &old);
> +	error = lookup_rename_source(&oldnd, &newnd, &trap, &oldnd.last, &old);

> +//	if (is_unionized(newnd.path.dentry, newnd.path.mnt))
> +//		goto exit5;

Nuke.

Erez.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/