linux-kernel - Re: [PATCH 2/2] perf timechart: Remove open-coded event parsing code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091130222431.78a300e7@infradead.org>
Date:	Mon, 30 Nov 2009 22:24:31 -0800
From:	Arjan van de Ven <arjan@...radead.org>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Frédéric Weisbecker <f.weisbecker@...il.com>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Peter Zijlstra <peterz@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] perf timechart: Remove open-coded event parsing
 code

On Tue, 01 Dec 2009 14:05:16 +0800
Li Zefan <lizf@...fujitsu.com> wrote:
> -		size = 8;
> +	if (!(sample_type & PERF_SAMPLE_RAW)) {
> +		fprintf(stderr,
> +			"No trace sample to read. Did you call perf
> record "
> +			"without -R?");
> +		return -1;
>  	}

while I like your cleanup... I am not so sure this printk makes sense
whatsoever.... the user did not use "perf record" to get here...



-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/