linux-kernel - Re: [PATCH] proc_fops: convert drivers/isdn/ to seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 02 Dec 2009 10:01:24 +0100
From:	Tilman Schmidt <tilman@...p.cc>
To:	Alexey Dobriyan <adobriyan@...il.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, isdn@...ux-pingi.de, mac@...ware.de
Subject: Re: [PATCH] proc_fops: convert drivers/isdn/ to seq_file

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2009-11-30 21:17 schrieb Alexey Dobriyan:
> On Mon, Nov 30, 2009 at 01:42:32AM +0100, Tilman Schmidt wrote:
>> Am 25.11.2009 05:59 schrieb Alexey Dobriyan:
>>> --- a/drivers/isdn/gigaset/capi.c
>>> +++ b/drivers/isdn/gigaset/capi.c
>>> @@ -2106,35 +2106,22 @@ static char *gigaset_procinfo(struct capi_ctr *ctr)
>>>  	return ctr->name;	/* ToDo: more? */
>>>  }
>>>  
>>> -/**
>>> - * gigaset_ctr_read_proc() - build controller proc file entry
>>> - * @page:	buffer of PAGE_SIZE bytes for receiving the entry.
>>> - * @start:	unused.
>>> - * @off:	unused.
>>> - * @count:	unused.
>>> - * @eof:	unused.
>>> - * @ctr:	controller descriptor structure.
>>> - *
>>> - * Return value: length of generated entry
>>> - */
>>> -static int gigaset_ctr_read_proc(char *page, char **start, off_t off,
>>> -			  int count, int *eof, struct capi_ctr *ctr)
>>> +static int gigaset_proc_show(struct seq_file *m, void *v)
>> I would prefer that, instead of throwing the kerneldoc comment away,
>> you adapted it to the new function. Specifically, I would like to
>> know what the second argument "void *v" is for.
> 
> Sorry, no.

Ok, if you don't want to do it, I'll wait whether this is merged
and see if I can come up with something sensible as a follow-up.
I guess that's part of the job of a driver maintainer.

>>> +static int gigaset_proc_open(struct inode *inode, struct file *file)
>>> +{
>>> +	return single_open(file, gigaset_proc_show, PDE(inode)->data);
[...]
>> So what is PDE(inode)->data and where does it get set to the
>> capi_ctr pointer for the device?
> 
> When you create proc entry, you set ->data for proc entry,
> it's accessible as PDE(inode)->data.

I see. So in the context of CAPI subsystem - CAPI driver relations,
it's the CAPI subsystem that assures this. You should mention that
in your patch to Documentation/isdn/INTERFACE.CAPI.

Thanks,
Tilman

- --
Tilman Schmidt                    E-Mail: tilman@...p.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFLFizkQ3+did9BuFsRAqOEAJ9hHkwjQoPZUEw1ivKI3J+c2/lgigCgmH0j
Y3t7ifiCcLpr9Gqb8gnNhe4=
=HlV+
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/