linux-kernel - Re: [PATCH 06/24] HWPOISON: abort on failed unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091202131150.GE18989@one.firstfloor.org>
Date:	Wed, 2 Dec 2009 14:11:50 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nick Piggin <npiggin@...e.de>, linux-mm@...ck.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/24] HWPOISON: abort on failed unmap

>  	 * Now take care of user space mappings.
> +	 * Abort on fail: __remove_from_page_cache() assumes unmapped page.
>  	 */
> -	hwpoison_user_mappings(p, pfn, trapno);
> +	if (hwpoison_user_mappings(p, pfn, trapno) != SWAP_SUCCESS) {
> +		res = -EBUSY;
> +		goto out;

It would be good to print something in this case.

Did you actually see it during testing?

Or maybe loop forever in the unmapper.

-Andi
-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/