linux-kernel - Re: [PATCH] mfd: twl4030: clarify the return value for read and write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091202134144.GL1361@nokia.com>
Date:	Wed, 2 Dec 2009 15:41:44 +0200
From:	Felipe Balbi <felipe.balbi@...ia.com>
To:	ext Amit Kucheria <amit.kucheria@...durent.com>
Cc:	List Linux Kernel <linux-kernel@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	List Linux Omap <linux-omap@...r.kernel.org>
Subject: Re: [PATCH] mfd: twl4030: clarify the return value for read and
 write

Hi,

On Wed, Dec 02, 2009 at 02:31:18PM +0100, ext Amit Kucheria wrote:
>@@ -298,10 +298,12 @@ int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
> 	ret = i2c_transfer(twl->client->adapter, twl->xfer_msg, 1);
> 	mutex_unlock(&twl->xfer_lock);
>
>-	/* i2cTransfer returns num messages.translate it pls.. */
>-	if (ret >= 0)
>-		ret = 0;
>-	return ret;
>+	/* i2c_transfer returns number of messages transferred */
>+	if (ret != 1) {
>+		pr_err("%s: twl4030_i2c_write failed to transfer all messages\n", DRIVER_NAME);

this line is over 80-chars

>+		return ret;
>+	} else

you should have {} here as well.

>+		return 0;
> }
> EXPORT_SYMBOL(twl4030_i2c_write);
>
>@@ -350,10 +352,13 @@ int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
> 	ret = i2c_transfer(twl->client->adapter, twl->xfer_msg, 2);
> 	mutex_unlock(&twl->xfer_lock);
>
>-	/* i2cTransfer returns num messages.translate it pls.. */
>-	if (ret >= 0)
>-		ret = 0;
>-	return ret;
>+	/* i2c_transfer returns number of messages transferred */
>+	if (ret != 2) {
>+		pr_err("%s: twl4030_i2c_read failed to transfer all messages\n", DRIVER_NAME);

over 80-chars

>+		return ret;
>+	}
>+	else

} else {

>+		return 0;

}

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/