linux-kernel - Re: [PATCH] NOMMU: use copy_*_user_page() in access_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B168107.8020708@analog.com>
Date:	Wed, 2 Dec 2009 23:00:23 +0800
From:	Jie Zhang <jie.zhang@...log.com>
To:	David Howells <dhowells@...hat.com>
CC:	Mike Frysinger <vapier@...too.org>, uclinux-dev@...inux.org,
	David McCullough <davidm@...pgear.com>,
	Greg Ungerer <gerg@...inux.org>,
	Paul Mundt <lethal@...ux-sh.org>, linux-kernel@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH] NOMMU: use copy_*_user_page() in access_process_vm()

On 12/02/2009 10:36 PM, David Howells wrote:
> Mike Frysinger<vapier@...too.org>  wrote:
>
>> -			len -= copy_to_user((void *) addr, buf, len);
>> +			copy_to_user_page(vma, NULL, NULL,
>> +					  (void *) addr, buf, len);
>>   		else if (!write&&  vma->vm_flags&  VM_MAYREAD)
>> -			len -= copy_from_user(buf, (void *) addr, len);
>> +			copy_from_user_page(vma, NULL, NULL,
>> +					    buf, (void *) addr, len);
>
> Hmmm...  With this, len isn't updated anymore, and so it alters the return
> value of access_process_vm(), and means ptrace_readdata() won't now return
> -EIO under some circumstances where it used to.  I'm not sure that matters,
> though.
>
This keeps access_process_vm() in nommu.c align with the one in 
memory.c. If this does really matter, someone or me can write another 
patch to take care of it for both MMU and !MMU later.


Jie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/