linux-kernel - Re: [PATCH] mmc: pxamci: call mmc_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f17812d70912020702n318089f0rd2e129b0e45458b2@mail.gmail.com>
Date:	Wed, 2 Dec 2009 23:02:55 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Daniel Mack <daniel@...aq.de>
Cc:	Pierre Ossman <pierre@...man.eu>, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	stable@...nel.org
Subject: Re: [PATCH] mmc: pxamci: call mmc_remove_host() before freeing 
	resources

On Wed, Dec 2, 2009 at 7:03 PM, Daniel Mack <daniel@...aq.de> wrote:
> On Wed, Dec 02, 2009 at 08:50:44AM +0800, Eric Miao wrote:
>> On Wed, Dec 2, 2009 at 1:17 AM, Daniel Mack <daniel@...aq.de> wrote:
>> > mmc_remove_host() will cause the mmc core to switch off the bus power by
>> > eventually calling pxamci_set_ios(). This function uses the regulator or
>> > the GPIO which have been freed already.
>> >
>> > This causes the following Oops on module unload.
>> >
>
> [...]
>
>> >
>> > Signed-off-by: Daniel Mack <daniel@...aq.de>
>> > Reported-by: Sven Neumann <s.neumann@...mfeld.com>
>> > Cc: Pierre Ossman <pierre@...man.eu>
>> > Cc: Eric Miao <eric.y.miao@...il.com>
>> > Cc: linux-mmc@...r.kernel.org
>> > Cc: linux-arm-kernel@...ts.infradead.org
>> > Cc: stable@...nel.org
>> > ---
>> >  drivers/mmc/host/pxamci.c |    4 ++--
>>
>> Looks like a correct fix to me.
>>
>> Acked-by: Eric Miao <eric.y.miao@...il.com>
>
> Would be good to still get this into .32 - who will take care of picking
> this?
>

I'll send a pull request, and see if Russell will be happy to send
another one in such a short time :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/