linux-kernel - Re: [PATCH] hugetlb: Abort a hugepage pool resize if a signal is pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1259767475.24696.2368.camel@nimitz>
Date:	Wed, 02 Dec 2009 07:24:35 -0800
From:	Dave Hansen <dave@...ux.vnet.ibm.com>
To:	Mel Gorman <mel@....ul.ie>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hugetlb: Abort a hugepage pool resize if a signal is
 pending

On Wed, 2009-12-02 at 14:15 +0000, Mel Gorman wrote:
> If a user asks for a hugepage pool resize but specified a large number, the
> machine can begin trashing. In response, they might hit ctrl-c but signals
> are ignored and the pool resize continues until it fails an allocation. This
> can take a considerable amount of time so this patch aborts a pool resize
> if a signal is pending.
> 
> [dave@...ux.vnet.ibm.com: His idea]
> Signed-off-by: Mel Gorman <mel@....ul.ie>
> ---
>  mm/hugetlb.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index af02ee8..a952cb8 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1238,6 +1238,9 @@ static unsigned long set_max_huge_pages(struct hstate *h, unsigned long count)
>  		if (!ret)
>  			goto out;
> 
> +		/* Bail for signals. Probably ctrl-c from user */
> +		if (signal_pending(current))
> +			goto out;

Thanks, Mel!

This will help m unwedge my system the next time I fat-finger an extra
zero or two into my hugepage pool size.

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/