linux-kernel - Re: [tip:core/locking] locking, x86: Slightly shorten __ticket_spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0912020857270.2872@localhost.localdomain>
Date:	Wed, 2 Dec 2009 09:05:00 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jan Beulich <JBeulich@...ell.com>
cc:	a.p.zijlstra@...llo.nl, mingo@...e.hu, tglx@...utronix.de,
	mingo@...hat.com, npiggin@...e.de, linux-kernel@...r.kernel.org,
	hpa@...or.com
Subject: Re: [tip:core/locking] locking, x86: Slightly shorten 
 __ticket_spin_trylock()



On Wed, 2 Dec 2009, Linus Torvalds wrote:
> 
> So stop making excuses. Just admit that 'bool' was wrong, and you made a 
> fundamental mistake in choosing it. The fact is, the compiler can do 
> whatever the hell it does, which is not necessarily sensible with any 
> other type. 'bool' really is special.

Btw, even if gcc just treats 'bool' as 'char' (which is the sane thing to 
do on x86 anyway - I don't see why it should ever do anything else), we 
actually mess up in the kernel and make that type confusion even worse.

Do this:

	git grep typedef.*bool

and then do this:

	git grep 'define bool'

and then sit down and cry silently.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/