[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091202185903.66e6709e@lxorguk.ukuu.org.uk>
Date: Wed, 2 Dec 2009 18:59:03 +0000
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Rodolfo Giometti <giometti@...ux.it>
Cc: linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>,
David Woodhouse <dwmw2@...radead.org>,
Dave Jones <davej@...hat.com>, Sam Ravnborg <sam@...nborg.org>,
Greg KH <greg@...ah.com>,
Randy Dunlap <randy.dunlap@...cle.com>,
Kay Sievers <kay.sievers@...y.org>,
"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
Michael Kerrisk <mtk.manpages@...il.com>,
Christoph Hellwig <hch@...radead.org>,
Rodolfo Giometti <giometti@...ux.it>
Subject: Re: [PATCH 06/11] pps: serial clients support.
On Wed, 2 Dec 2009 18:18:44 +0100
Rodolfo Giometti <giometti@...ux.it> wrote:
> Adds support, by using the PPS line discipline, for the PPS sources
> connected with the CD (Carrier Detect) pin of a serial port.
I would suggest one change here - but the pps-ldisc bits into the n_tty.c
file then you don't have to export everything. That or just export the
n_tty ops struct.
I think putting the pps ldisc (which is basically n_tty and a bit) into
n_tty is probably the right choice given how small and clean it is - what
do you think ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists