linux-kernel - Re: [PATCH 2/2] Fix a bug on appledisplay.c regarding signedness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 02 Dec 2009 22:38:27 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	pancho horrillo <pancho@...cho.name>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Fix a bug on appledisplay.c regarding signedness

Hello.

pancho horrillo wrote:

> Please, review and push the patch, if you deem it adequate.

> Thanks a bunch!

> Signed-off-by: pancho horrillo <pancho@...cho.name>

> diff -purN a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c
> --- a/drivers/usb/misc/appledisplay.c	2009-11-10 01:32:31.000000000 +0100
> +++ b/drivers/usb/misc/appledisplay.c	2009-12-02 20:05:00.000000000 +0100
> @@ -72,8 +72,8 @@ struct appledisplay {
>  	struct usb_device *udev;	/* usb device */
>  	struct urb *urb;		/* usb request block */
>  	struct backlight_device *bd;	/* backlight device */
> -	char *urbdata;			/* interrupt URB data buffer */
> -	char *msgdata;			/* control message data buffer */
> +	uint8_t *urbdata;		/* interrupt URB data buffer */
> +	uint8_t *msgdata;		/* control message data buffer */

    That 'uint8_t' is for userspace, use 'u8' instead.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/