linux-kernel - Re: avoiding duplicate icache flushing of shared maps on nommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 Dec 2009 17:41:31 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	David Howells <dhowells@...hat.com>
Cc:	Paul Mundt <lethal@...ux-sh.org>,
	Bernd Schmidt <bernds_cb1@...nline.de>,
	Jie Zhang <jie.zhang@...log.com>,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	uclinux-dist-devel <uclinux-dist-devel@...ckfin.uclinux.org>
Subject: Re: avoiding duplicate icache flushing of shared maps on nommu

On Wed, Dec 2, 2009 at 09:15, David Howells wrote:
> Mike Frysinger wrote:
> +               flush_icache_range(region->vm_start,
> +                                  region->vm_end - region->vm_start);
> -               flush_icache_range(result, result + len);

actually, there's one typo here.  you want:
flush_icache_range(region->vm_start, region->vm_end);

it doesnt crash on blackfin systems as addresses not in icache get
nopped, but it was causing large delays on exec mappings.  i thought
this was due to the nic on the board i was using as it's hitting some
weird pauses by itself.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/