linux-kernel - Re: [PATCH][stable] b44 WOL setup: one-bit-off stack corruption kernel panic fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091202.154220.118775778.davem@davemloft.net>
Date:	Wed, 02 Dec 2009 15:42:20 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sbrabec@...e.cz
Cc:	zambrano@...adcom.com, linux-kernel@...r.kernel.org,
	stable@...nel.org
Subject: Re: [PATCH][stable] b44 WOL setup: one-bit-off stack corruption
 kernel panic fix

From: Stanislav Brabec <sbrabec@...e.cz>
Date: Wed, 02 Dec 2009 15:35:20 +0100

> Stanislav Brabec wrote:
>> About 50% of shutdowns of b44 Ethernet adapter ends by kernel panic with
>> kernels compiled with stack-protector.
>> 
>> Checking b44_magic_pattern() return values, one call of
>> b44_magic_pattern() returns 127. It means, that set_bit(128, pmask) was
>> called on line 1509. It means that bit 0 of 17th byte of pmask was
>> overwritten. But pmask has only 16 bytes. Stack corruption happens.
>>  
>> It seems that set_bit() on line 1509 always writes one bit off.
>> 
>> The fix does not only solve the stack corruption, but also makes Wake On
>> LAN working on my onboard B44 on Asus A7V-333X mainboard.
>> 
>> It seems that this problem affects all kernel versions since commit
>> 725ad800 on 2006-06-20.
> 
> stable@...nel.org may be interested as well. Adding Cc:.

netdev@...r.kernel.org is even more interested.  Please post all
networking patches CC:'d there so they get properly logged
and tracked in patchwork.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/