linux-kernel - Re: [tip:perf/core] trace_syscalls: Remove unused event_syscall_enter and event_syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091202042411.GA5428@nowhere>
Date:	Wed, 2 Dec 2009 05:24:14 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	rostedt@...dmis.org, jbaron@...hat.com, tglx@...utronix.de,
	mingo@...e.hu, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/core] trace_syscalls: Remove unused
	event_syscall_enter and event_syscall_exit

On Wed, Dec 02, 2009 at 09:13:50AM +0800, Lai Jiangshan wrote:
> Frederic Weisbecker wrote:
> 
> > 
> > Except for this patch. The whole series is really nice, thanks
> > a lot for this cleanup!
> > 
> > 
> > 
> 
> > But I think you fixed it the wrong way.
> > 
> > Why do we need a copy of this event_syscall_enter
> > for each syscall event?
> > Can't we actually drop enter_syscall_print_##sname
> > and always use event_syscall_enter instead?
> > 
> > The same applies to exit syscall events.
> > 
> > Thanks.
> > 
> 
> 64c12e0444fcc6b75eb49144ba46d43dbdc6bc8f is a nice patch from
> Jason Baron, this patch introduces enter_syscall_print_##sname.
> 
> This patch only forgot to do some cleanups. My patch make up it:
> 
> fix event_enter_##sname->event
> fix event_exit_##sname->event
> 
> remove unused event_syscall_enter and event_syscall_exit
> 
> Thanks,
> Lai


Ah right I forgot about this. We need different enter_syscall_print_##sname
so that we can have different event ids for each syscalls.

Ok, fine then, thanks :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/