linux-kernel - Re: [PATCH 06/11] pps: serial clients support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091203105347.GB12943@gundam.enneenne.com>
Date:	Thu, 3 Dec 2009 11:53:47 +0100
From:	Rodolfo Giometti <giometti@...eenne.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Dave Jones <davej@...hat.com>, Sam Ravnborg <sam@...nborg.org>,
	Greg KH <greg@...ah.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Kay Sievers <kay.sievers@...y.org>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Michael Kerrisk <mtk.manpages@...il.com>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH 06/11] pps: serial clients support.

On Wed, Dec 02, 2009 at 06:59:03PM +0000, Alan Cox wrote:
> On Wed,  2 Dec 2009 18:18:44 +0100
> Rodolfo Giometti <giometti@...ux.it> wrote:
> 
> > Adds support, by using the PPS line discipline, for the PPS sources
> > connected with the CD (Carrier Detect) pin of a serial port.
> 
> I would suggest one change here - but the pps-ldisc bits into the n_tty.c
> file then you don't have to export everything. That or just export the
> n_tty ops struct.
> 
> I think putting the pps ldisc (which is basically n_tty and a bit) into
> n_tty is probably the right choice given how small and clean it is - what
> do you think ?

I think it could be ok, but in this case where should I register
pps-ldisc? Into tty_ldisc_begin just after tty_ldisc_N_TTY?

Again, should I remove the possibility to compile pps-ldisc as module?

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti@...eenne.com
Linux Device Driver                          giometti@...ux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/