[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1259850233.2613.0.camel@localhost>
Date: Thu, 03 Dec 2009 09:23:53 -0500
From: Eric Paris <eparis@...hat.com>
To: Amerigo Wang <amwang@...hat.com>
Cc: linux-kernel@...r.kernel.org, Eric Paris <eparis@...isplace.org>,
linux-security-module@...r.kernel.org, akpm@...ux-foundation.org,
James Morris <jmorris@...ei.org>
Subject: Re: [Patch] selinux: remove a useless return
On Thu, 2009-12-03 at 03:48 -0500, Amerigo Wang wrote:
> The last return is unreachable, remove the 'return'
> in default, let it fall through.
>
> Signed-off-by: WANG Cong <amwang@...hat.com>
> Cc: James Morris <jmorris@...ei.org>
> Cc: Eric Paris <eparis@...isplace.org>
Acked-by: Eric Paris <eparis@...hat.com>
>
> ---
>
> diff --git a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c
> index b5407f1..718823d 100644
> --- a/security/selinux/ss/mls.c
> +++ b/security/selinux/ss/mls.c
> @@ -542,7 +542,7 @@ int mls_compute_sid(struct context *scontext,
> /* Use the process effective MLS attributes. */
> return mls_context_cpy_low(newcontext, scontext);
> default:
> - return -EINVAL;
> + /* Fallthrough */
> }
> return -EINVAL;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists