linux-kernel - Re: [PATCH 2.6.32] x86: enable lapic nmi watchdog on AMD Family 11h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091203152952.GA27324@elte.hu>
Date:	Thu, 3 Dec 2009 16:29:52 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Mikael Pettersson <mikpe@...uu.se>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Joerg Roedel <joerg.roedel@....com>,
	Andreas Herrmann <andreas.herrmann3@....com>,
	Yinghai Lu <yinghai@...nel.org>,
	Suresh Siddha <suresh.b.siddha@...el.com>
Subject: Re: [PATCH 2.6.32] x86: enable lapic nmi watchdog on AMD Family 11h


* Mikael Pettersson <mikpe@...uu.se> wrote:

> The x86 lapic nmi watchdog does not recognize AMD Family 11h, 
> resulting in:
> 
> NMI watchdog: CPU not supported
> 
> As far as I can see from available documentation (the BKDM), family 
> 11h looks identical to family 10h as far as the PMU is concerned.
> 
> Extending the check to accept family 11h results in:
> 
> Testing NMI watchdog ... OK.
> 
> I've been running with this change on a Turion X2 Ultra ZM-82 laptop 
> for a couple of weeks now without problems.

Applied, thanks Mikael!

Long term i think we want to use the PMU driver to support the NMI tick, 
that way all new CPUs that have PMU support will get NMI watchdog 
support too, automatically.

That's a more complex change though and there's no reason not to apply 
this simple patch of yours. Btw., do you [or anyone else] have 
interest/time to pursue the more complex angle as well? It would be a 
nice feature.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/