linux-kernel - Re: [PATCH] atbm8830: replace 64-bit division and floating point usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091203092501.118ecf81.randy.dunlap@oracle.com>
Date:	Thu, 3 Dec 2009 09:25:01 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	"David T. L. Wong" <davidtlwong@...il.com>
Cc:	linux-next@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	LKML <linux-kernel@...r.kernel.org>, linux-media@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...radead.org>
Subject: Re: [PATCH] atbm8830: replace 64-bit division and floating point
 usage

On Thu, 03 Dec 2009 21:57:02 +0800 David T. L. Wong wrote:

> Randy Dunlap wrote:
> > On Mon, 30 Nov 2009 10:07:21 -0800 Randy Dunlap wrote:
> > 
> >> Stephen Rothwell wrote:
> >>> Hi all,
> >>>
> >>> Changes since 20091127:
> >>>
> >>> The v4l-dvb tree lost its conflict.
> >>
> >> on i386 (X86_32):
> >>
> >> a 'double' variable is used, causing:
> >>
> >> ERROR: "__floatunsidf" [drivers/media/common/tuners/max2165.ko] undefined!
> >> ERROR: "__adddf3" [drivers/media/common/tuners/max2165.ko] undefined!
> >> ERROR: "__fixunsdfsi" [drivers/media/common/tuners/max2165.ko] undefined!
> > 
> > 
> > linux-next-20091202:
> > 
> > still have this one (above) and similar with
> > drivers/media/dvb/frontends/atbm8830.c:
> > 
> > drivers/built-in.o: In function `atbm8830_init':
> > atbm8830.c:(.text+0x9012f9): undefined reference to `__udivdi3'
> > atbm8830.c:(.text+0x901384): undefined reference to `__floatunsidf'
> > atbm8830.c:(.text+0x901395): undefined reference to `__muldf3'
> > atbm8830.c:(.text+0x9013a5): undefined reference to `__floatunsidf'
> > atbm8830.c:(.text+0x9013b2): undefined reference to `__divdf3'
> > atbm8830.c:(.text+0x9013c3): undefined reference to `__muldf3'
> > atbm8830.c:(.text+0x9013cd): undefined reference to `__fixunsdfsi'
> > 
> > ---
> This patch replace 64-bit division by do_div() macro and remove usage of 
> floating point variable
> 
> Signed-off-by: David T. L. Wong <davidtlwong@...il.com>

Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/