linux-kernel - RE: [PATCH] DFU Driver for Atheros bluetooth chipset AR3011

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1259862126.30413.2.camel@localhost.localdomain>
Date:	Thu, 03 Dec 2009 18:42:06 +0100
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Vikram Kandukuri <Vikram.Kandukuri@...eros.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
	Luis Rodriguez <Luis.Rodriguez@...eros.com>
Subject: RE: [PATCH] DFU Driver for Atheros bluetooth chipset AR3011

Hi Vikram,

> Signed-off-by: Vikram Kandukuri <Vikram.Kandukuri@...eors.com>

so first of all, you should learn how to write you employers name.

> Signed-off-by: Alicke Xu <sxu@...eros.com>
> Reviewed-by: Luis R. Rodriguez <lrodriguez@...eros.com>
> 
> ---
>  drivers/bluetooth/Kconfig  |   12 +++
>  drivers/bluetooth/Makefile |    1 +
>  drivers/bluetooth/ath3k.c  |  191 ++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 204 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/bluetooth/ath3k.c
> 
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index 652367a..89f079e 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -195,5 +195,17 @@ config BT_MRVL_SDIO
>           Say Y here to compile support for Marvell BT-over-SDIO driver
>           into the kernel or say M to compile it as module.
> 
> +config BT_ATH3K
> +       tristate "Atheros firmware download driver"
> +       depends on BT_HCIBTUSB
> +       select FW_LOADER
> +       help
> +         Bluetooth firmware download driver.
> +         This driver loads the firmware into the Atheros bluetooth
> +          chipset.
> +
> +         Say Y here to compile support for "Atheros AR30XX firmware download driver"
> +          into the  kernel or say M to compile it as module (ath3k).
> +
>  endmenu
> 
> diff --git a/drivers/bluetooth/Makefile b/drivers/bluetooth/Makefile
> index b3f57d2..6fcdeb7 100644
> --- a/drivers/bluetooth/Makefile
> +++ b/drivers/bluetooth/Makefile
> @@ -15,6 +15,7 @@ obj-$(CONFIG_BT_HCIBTUART)    += btuart_cs.o
>  obj-$(CONFIG_BT_HCIBTUSB)      += btusb.o
>  obj-$(CONFIG_BT_HCIBTSDIO)     += btsdio.o
> 
> +obj-$(CONFIG_BT_ATH3K)         += ath3k.o
>  obj-$(CONFIG_BT_MRVL)          += btmrvl.o
>  obj-$(CONFIG_BT_MRVL_SDIO)     += btmrvl_sdio.o

The Makefile and Kconfig changes don't apply at all. No idea how you
screwed that up, but you did.

> +MODULE_DEVICE_TABLE(usb, ath3k_table);
> +
> +#define USB_REQ_DFU_DNLOAD     1
> +#define FIRST_20BYTE            20

The FIRST_20BYTE is not used. So remove it.

> +#define BULK_SIZE               4096
> +
> +#define ATHBT_IN_EP(data)       (0x81)
> +#define ATHBT_OUT_EP(data)     (0x02)

This is not used either and wrong on so many levels. Remove it.

> +struct ath3k_data {
> +       struct usb_device *udev;
> +       u8 *fw_data;
> +       u32 fw_size;
> +       u32 fw_sent;
> +};
> +

And from here on. Please use tabs and not spaces. Did you actually run
checkpatch.pl on this patch?

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/