linux-kernel - Re: [PATCH] HID: add multi-input quirk for NextWindow Touchscreen.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B1836A6.405@redhat.com>
Date:	Fri, 04 Dec 2009 08:07:34 +1000
From:	Peter Hutterer <peter.hutterer@...hat.com>
To:	Peter Korsgaard <jacmet@...site.dk>
CC:	Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: add multi-input quirk for NextWindow Touchscreen.

On 03/12/09 22:15, Peter Korsgaard wrote:
>>>>>> "Peter" == Peter Hutterer<peter.hutterer@...hat.com>  writes:
>
>   Peter>  These touchscreens are mounted onto HP TouchSmart and the Dell
>   Peter>  Studio One 19. Without a quirk they report a wrong button set
>   Peter>  and the x/y coordinates through ABS_Z/ABS_RX, confusing the
>   Peter>  higher levels (most notably X.Org's evdev driver).
>
> What exactly does this fix? I've been using NW touchscreens for a while
> and don't recall any issues (admittedly only used it with evtouch).

evtouch has the following code:

         if ( (ev->code == ABS_X) || (ev->code == ABS_Z) ) {
                 priv->raw_x = ev->value;
                 pos_changed = 1;
         }

         if ( (ev->code == ABS_Y) || (ev->code == ABS_RX) ) {
                 priv->raw_y = ev->value;
                 pos_changed = 1;
         }

it's a hack in userspace that works around wrong event reporting. So 
yes, it works if you're using evtouch but if you want to use any other 
driver that driver needs the same hack. treating Z as X and RX as Y 
doesn't work too well for a generic driver such as evdev, which has to 
deal with devices where RX is a valid axis.

Cheers,
   Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/