linux-kernel - Re: [Patch 1/2] GRU - function to generate chipset IPI values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 Dec 2009 17:31:17 -0600
From:	Jack Steiner <steiner@....com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [Patch 1/2] GRU - function to generate  chipset IPI values

On Thu, Dec 03, 2009 at 03:19:12PM -0800, Andrew Morton wrote:
> On Thu, 03 Dec 2009 16:34:15 -0600
> steiner@....com wrote:
> 
> > From: Jack Steiner <steiner@....com>
> > 
> > Create a function to generate the value that is written to the UV hub
> > MMR to cause an IPI interrupt to be sent. The function will be
> > used in the GRU message queue error recovery code that sends IPIs to
> > nodes in remote partitions.
> > 
> > ...
> >
> > +static unsigned long uv_hub_ipi_value(int apicid, int vector, int mode)
> > +{
> > +	return (1UL << UVH_IPI_INT_SEND_SHFT) |
> > +			((apicid) << UVH_IPI_INT_APIC_ID_SHFT) |
> > +			(mode << UVH_IPI_INT_DELIVERY_MODE_SHFT) |
> > +			(vector << UVH_IPI_INT_VECTOR_SHFT);
> > +}
> 
> You've taken care to avoid a shift overflow of "1", but not of
> `apicid', `vector' and `mode'.
> 
> Maybe the compiler does that, I forget.
 
I sure hate the 32/64 bit issues with shifts of ints. I am bitten by
that more than I'd like.

I think we are ok in this case.  In the above code, all of the fields
of the result except bit 63 reside in the low 32 bits of the resulting
unsigned long. I think that makes it work.

--- jack
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/