linux-kernel - [PATCH] [SCSI] megaraid_sas: remove sysfs dbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <1259767064-13738-1-git-send-email-cdahlin@redhat.com>
Date:	Wed, 02 Dec 2009 10:17:44 -0500
From:	Casey Dahlin <cdahlin@...hat.com>
To:	linux-kernel@...r.kernel.org
Cc:	eteo@...hat.com, "Bryn M. Reeves" <bmr@...hat.com>,
	Casey Dahlin <cdahlin@...hat.com>,
	Neela Syam Kolli <megaraidlinux@....com>,
	"James E.J. Bottomley" <James.Bottomley@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Yang Hongyang <yanghy@...fujitsu.com>,
	Anand Gadiyar <gadiyar@...com>, Jiri Kosina <jkosina@...e.cz>,
	linux-scsi@...r.kernel.org
Subject: [PATCH] [SCSI] megaraid_sas: remove sysfs dbg_lvl world writeable
 permissions

From: Bryn M. Reeves <bmr@...hat.com>

/sys/bus/pci/drivers/megaraid_sas/poll_mode_io defaults to being
world-writable, which seems bad (letting any user affect kernel driver
behavior).

This turns off group and user write permissions, so that on typical
production systems only root can write to it.

Signed-off-by: Bryn M. Reeves <bmr@...hat.com>
Signed-off-by: Casey Dahlin <cdahlin@...hat.com>
---
 drivers/scsi/megaraid/megaraid_sas.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas.c b/drivers/scsi/megaraid/megaraid_sas.c
index a39addc..08a7f49 100644
--- a/drivers/scsi/megaraid/megaraid_sas.c
+++ b/drivers/scsi/megaraid/megaraid_sas.c
@@ -3451,7 +3451,7 @@ out:
 	return retval;
 }
 
-static DRIVER_ATTR(poll_mode_io, S_IRUGO|S_IWUGO,
+static DRIVER_ATTR(poll_mode_io, S_IRUGO|S_IWUSR,
 		megasas_sysfs_show_poll_mode_io,
 		megasas_sysfs_set_poll_mode_io);
 
-- 
1.6.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/