linux-kernel - Re: [uClinux-dev] Re: [PATCH] FDPIC: respect PT_GNU_STACK exec markings when creating NOMMU stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 4 Dec 2009 05:26:46 -0500
From:	Mike Frysinger <vapier@...too.org>
To:	David Howells <dhowells@...hat.com>
Cc:	uclinux-dev@...inux.org, linux-kernel@...r.kernel.org,
	Greg Ungerer <gerg@...inux.org>,
	uclinux-dist-devel@...ckfin.uclinux.org,
	David McCullough <davidm@...pgear.com>
Subject: Re: [uClinux-dev] Re: [PATCH] FDPIC: respect PT_GNU_STACK exec markings when creating NOMMU stack

On Friday 04 December 2009 04:40:32 David Howells wrote:
> Mike Frysinger <vapier@...too.org> wrote:
> > > 	+	flush_icache_range(mm->brk, brk);
> > > 		return mm->brk = brk;
> > > 	 }
> >
> > probably want mm->brk + brk for the second argument
> 
> Ummm...  Why?  mm->brk and brk are both addresses - note the return
>  statement where brk just gets assigned to mm->brk.

yeah, sorry.  i was thinking sbrk where the argument is an increment, not a 
new address.
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)