linux-kernel - Re: [PATCH] security: do not check mmap_min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32275.1259923944@redhat.com>
Date:	Fri, 04 Dec 2009 10:52:24 +0000
From:	David Howells <dhowells@...hat.com>
To:	Eric Paris <eparis@...hat.com>
Cc:	dhowells@...hat.com, linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org, akpm@...ux-foundation.org,
	gyang@...ckfin.uclinux.org, john.johansen@...onical.com
Subject: Re: [PATCH] security: do not check mmap_min_addr on nommu systems

Eric Paris <eparis@...hat.com> wrote:

> +/* sec_flags for security_file_mmap */
> +/* Only check the address portion */
> +#define SECURITY_MMAP_ADDR_ONLY	0x01
> +/* Do not do the address checks */
> +#define SECURITY_MMAP_NOT_ADDR	0x02

I'm still not happy with the names assigned to these constants.  

Can we call them:

#define SECURITY_MMAP_ADDR_CHECK_ONLY	0x01
#define SECURITY_MMAP_SKIP_ADDR_CHECK	0x02

and then discard the comments?

Also, the big banner comment in security.h that describes all the function
pointers does not make any mention of this argument.  Can you fix that too,
please?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/