lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091204191754.GI21174@sequoia.sous-sol.org>
Date:	Fri, 4 Dec 2009 11:17:54 -0800
From:	Chris Wright <chrisw@...s-sol.org>
To:	jbarnes@...tuousgeek.org, Allen Kay <allen.m.kay@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	matthew@....cx, chris@...s-sol.org, jeremy@...p.org,
	don.dugger@...el.com
Subject: Re: [ACS PATCH v5 1/2] acs p2p upsteram forwarding enabling

* Allen Kay (allen.m.kay@...el.com) wrote:
> Changes from v4 to v5:
> 	- separate out dom0 checking out of v4
> 	- use iommu_found() for detecting HW iommu presence

Erk, turns out iommu_found() doesn't work (becuase the iommu has been
detected, but not initialized yet when this code runs).

This could be fixed in a few ways:

1) Have an isolation capable iommu actively ask for ACS to be enabled
2) Have pci core switch to iommu_detected (as Allen had done earlier).
This would need some work to make iommu_detected actually defined on
all arches that make use of pci.  iommu_detected could be more
descriptive than a single boolean, turned into an enum that says what
kind of hw iommu was detected.
3) Just always enable ACS and pay the price.

I'll send a patch for option 1) momentarily.

Thoughts?

thanks,
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ