linux-kernel - Re: [PATCH] virtio: set pci bus master enable bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091204151014.22a39388@jbarnes-piketon>
Date:	Fri, 4 Dec 2009 15:10:14 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	"Michael S. Tsirkin" <mst@...hat.com>,
	Mark McLoughlin <markmc@...hat.com>,
	linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org,
	Anthony Liguori <anthony@...emonkey.ws>, kvm@...r.kernel.org,
	Yan Vugenfirer <yvugenfi@...hat.com>
Subject: Re: [PATCH] virtio: set pci bus master enable bit

On Tue, 1 Dec 2009 10:34:01 +1030
Rusty Russell <rusty@...tcorp.com.au> wrote:

> On Mon, 30 Nov 2009 02:22:01 am Michael S. Tsirkin wrote:
> > As all virtio devices perform DMA, we
> > must enable bus mastering for them to be
> > spec compliant.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> > ---
> >  drivers/virtio/virtio_pci.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/virtio/virtio_pci.c
> > b/drivers/virtio/virtio_pci.c index 28d9cf7..717bae1 100644
> > --- a/drivers/virtio/virtio_pci.c
> > +++ b/drivers/virtio/virtio_pci.c
> > @@ -648,6 +648,7 @@ static int __devinit virtio_pci_probe(struct
> > pci_dev *pci_dev, goto out_req_regions;
> >  
> >  	pci_set_drvdata(pci_dev, vp_dev);
> > +	pci_set_master(pci_dev);
> 
> I can believe this, but I have no idea if it's right.  I've applied
> it, and hope Jesse will comment if there's something wrong with it.

Nope, nothing wrong with that afaict.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/