linux-kernel - Re: [PATCH] Driver core: fix race in dev_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0912041844450.5593-100000@netrider.rowland.org>
Date:	Fri, 4 Dec 2009 18:50:35 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
cc:	Oliver Neukum <oliver@...kum.org>, Greg KH <gregkh@...e.de>,
	<stable@...nel.org>,
	Rickard Bellini <rickard.bellini@...csson.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	Torgny Johansson <torgny.johansson@...csson.com>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Driver core: fix race in dev_driver_string

On Fri, 4 Dec 2009, Dmitry Torokhov wrote:

> > Maybe reference counting is inelegant; it depends on your point of
> > view.  Can you think of a more elegant way to make sure that a pointer
> > isn't stale?
> 
> Yes, just say "no" to device_create() and friends.

device_create() wasn't used in the case Oliver is discussing.

>  Embed device structure in
> yours,

You can't do that when the device structure wasn't created by your 
driver.

>  be mindful of lifetime rules and only use "your" device (i.e device
> bound to your driver).

What do you mean by "use"?  In Oliver's case he wasn't using the
device, he was using the device structure.  (Maybe that's what you
meant.)  And he wanted to use it at a time when it wasn't bound to his
driver, because userspace still had an open file reference to it.  
There isn't really any way around this.

> This way, as long as your refcount your instance you
> can rest assured the device structure is there as well.

I rather think that a simple device_get() and device_put() is easier 
than trying to follow a bunch of rules, especially in cases where they 
don't apply!  :-)

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/